Repository navigation
v0.5: backport PR 214 - #217
Merged
Merged
Conversation
…iled [ upstream commit 6917b43 ] [ backporter's notes: Port the pruning regressions to the internal test package and synchronize the reconciliation loop with channels instead of synctest, retaining Go 1.24 compatibility. Cover concurrent writes, failed attempts, empty tables with nonzero revisions, and both single and batch operations. ] Regression test for checking that pruning only happens once reconciliation has been attempted on all objects that existed at the time the table become initialized. AIL:3 Signed-off-by: Jussi Maki <jussi@isovalent.com>
[ upstream commit 2514f53 ] [ backporter's notes: Use the v0.5 incremental.run API and change iterator. Omit the upstream revision/progress bookkeeping changes because v0.5 does not provide revision-based progress tracking; initial pruning uses snapshot exhaustion. AIL:3 for the backport ] Pruning was invoked after the table had initialized but not before the initial set was reconciled. This is an issue when the Update and Prune operations have a dependency on each other, e.g. Prune reads internal state populated by Update. Fix this by only pruning once reconciliation has been attempted at least up to the revision at which the table has been initialized. AIL:0 Signed-off-by: Jussi Maki <jussi@isovalent.com>
[ upstrem commit d1a0840 ] From now on also run CI checks for PRs targeting v0.* and also after merging. Signed-off-by: Jussi Maki <jussi@isovalent.com>
|
Hi, as I see v1.18 on 0.4 |
Contributor
Author
|
Oops yeah should've been that way around. |
[ upstream commit 3c6df79 ] We started seeing the error of the pr workflow [^1]: Run thollander/actions-comment-pull-request@v2 No comment has been found with asked pattern. Creating a new comment. Error: Resource not accessible by integration According to the thollander/actions-comment-pull-request action's README[^2] we need to add pull-requestes: write permissions to the workflow. Do that and also update the action to v3 while at it. [^1]: #151 (comment) [^2]: https://github.com/thollander/actions-comment-pull-request/blob/e4a76dd2b0a3c2027c3fd84147a67c22ee4c90fa/README.md?plain=1#L172-L181 Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Jussi Maki <jussi@isovalent.com>
|
pippolo84
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #214 to bring the fix to Cilium v1.19.